Bashscripts.org

Hi folks,

I am trying to automate part of my backup routines and have brickwalled myself with what appears to be a quoting problem. You will see that I have a "workaround": I create a temporary script and execute it. However, if I try to do the more intuitive "execution in place", it seems that rsync complains.

Any idea why I am not able to execute the command without creating the temporary script.



Thanks for the help on this site.

I have the same sort of thing with my script. If I run the output of the echo command it works, but the same command as part of this script doesn't and I get the following error:
rsync: -rptgoDLKv --safe-links --exclude-from=/home/admin/etc/rsync-exclude: unknown option

I'm spooked.


script with error:
DOMAINS=/home/admin/etc/webserver.conf
STRIPPED=/tmp/webserver
PREFIX="`date` WebServer |"
ARGS="-rptgoDLKv --safe-links --exclude-from=/home/admin/etc/rsync-exclude"

# strip the conf file of comments
egrep -v '(^[[:space:]]*#|^[[:space:]]*$)' $DOMAINS > $STRIPPED
# set the file separator
IFS="|"
for file in $STRIPPED
do
if [ -e "$file" ]
then
while read -r USER DOMAIN
do
echo "rsync $ARGS ${USER}@${DOMAIN}:/home/${USER}/ $TARGET/webserver/${DOMAIN}/" # this works as a terminal command!
rsync $ARGS $USER@$DOMAIN:/home/$USER/ $TARGET/webserver/${DOMAIN}/ # this generates the unknown option
if [ "$?" = "0" ]
then
echo "$PREFIX Backup of $DOMAIN successfull" >> $LOGFILE
else
MSG="$PREFIX ERROR ($?) backing up $DOMAIN" >> $LOGFILE
echo $MSG >> $LOGFILE
echo $MSG | mailx -s "Webserver: Error daily syncing etc" $EMAIL
fi
done < "$file"
fi
done
unset IFS

short script which does works:
DOMAIN=mydomain.com
SOURCE="myuser@$DOMAIN:/home/myuser/"
if rsync $ARGS $SOURCE /media/nas/admin/webserver/$DOMAIN/
then
echo "$PREFIX Backup of $DOMAIN successfull" >> $LOGFILE
else
MSG="$PREFIX ERROR ($?) backing up $DOMAIN" >> $LOGFILE
echo $MSG >> $LOGFILE
echo $MSG | mailx -s "Webserver: Error daily syncing etc" $EMAIL
fi

Yes, it is a quoting problem. Try adding -xv to your shebang line to see what you really tell the shell to execute.

You both have to use an array to store the arguments. It fails because of wordsplitting.



Also, you don't need to explicitly write where the binaries are. Just adjust your PATH. (and I hope it contains /usr/bin, heh...)

----



----

And don't use uppercase variables. They're meant to be variables of the shell environment, per convention, so you could overwrite one not on purpose.