Bashscripts.org

I'm trying to search a xml file, find a line containing a string and if the line is not a comment, replace a line with a new line which is a variable.

code:
WIN_IMAGE='<general image="c:\program files\adacel\sysman\client\Sysman.jpg"/>'

# Modify the image file location
sed '/<!--/!s/<general image=*/$WIN_IMAGE/g' $TMP_DIR/"Sysman.xml" > $TMP_DIR/"1.xml"

The result is a line containing the literal characters "$WIN_IMAGE" instead of the string in the variable.

What i'm I doing wrong?

Thanks

Where are you doing it in your code?



Again, where is this task?

------

So there are two issues in your sed(1) line.

The first one is that you want to expand the variable WIN_IMAGE by its value,
using the dollar sign, within single quotes, whereas expansion occurs within double quotes.

The second is that the variable WIN_IMAGE contains the "/" character, so sed(1) will treat it as one of its delimiters.
The solution to this issue is to use another delimiter, like a comma, for example.

Also, I'd use the "${...}" syntax to make the command more readable, and use lowercase variables because they aren't part of the shell environment.



Note that this sed(1) command won't work if you're in an interactive shell with history expansion enabled.
To disable it, run set +H. ( « help set » )