Bashscripts.org

I'm a bit of a newbie at bash script so appologies if this is a "schoolboy" question...

I need to create a script that will rename all files ending in '.jpg' in the current directory to '29-04-11-{current filename}'

I can run the following code at the terminal and it does what I want...



...but when I create a script with the same command in...



...it fails with a 'command not found'. This is the terminal output showing the read/write/execute bits set alright...



I know this is probably down to something simple but I just can't figure out why it won't run

Once it's working I want to make the '29-04-11' part a variable that's passed into the script.
Could somebody point me in the right direction please.

Hello Mark!

Is the script executable? Try running it like this:



This does two things... First, you're executing the script directly via /bin/bash. Second, if you run it with "-x" and it still has errors, you can see step by step what it's doing, and where it's failing.

I hope this helps!

Thanks Jeo,
adding the /bin/bash before it on the command line worked
but I don't really understand why? I thought that the #!/bin/bash at the top of the script told it where to run?
...maybe there's something wrong with my bashrc file?

The -x parameter didn't show any errors.

Apparently, you missed this question, or thought it was connected with jeo's given command:



You can't execute your script because it's not executable.
To make it executable, you have to use chmod(1).

Hi,

You are calling the script like so;


however if the directory script-test is not in your path then it'll not find the rename_images.sh script to run it, giving the error you found. Call the script with the path and it'll be fine;



Note the "./" at the start of the script name.

DW

Oh yeah, that too.

@Mark Williamson: you can check out a perl script called rename(1) and mmv(1).